18F / pulse

How the federal .gov domain space is doing at best practices and policies.
Other
95 stars 56 forks source link

Was using wrong variable name to sanity check eligible reports #794

Closed konklone closed 6 years ago

konklone commented 6 years ago

The data/processing.py script was using subdomain_name instead of name to index reports when sanity-checking them during processing. The subdomain_name variable would have referred to the result of unrelated use prior.

It seems to have been practically harmless (the sanity checking was just out of an abundance of caution), and this change doesn't affect the calculated numbers (or create/remove any new warning or exceptions) during data processing at all. It's good to fix it though, since it could have been the cause of new unexpected bugs if the subdomain_name value had ever changed, or if another change would have made the sanity-checking necessary or useful.