Tweak use of setdefault to not collide with existing local variable

18F / pulse

How the federal .gov domain space is doing at best practices and policies.

Other

94 stars 56 forks source link

Tweak use of setdefault to not collide with existing local variable #797

Closed konklone closed 6 years ago

konklone commented 6 years ago

This tweaks the work from the PR @buckley-w-david filed in #795 to avoid colliding with the existing subdomains variable. The setdefault code works fine, but the use of a local variable named subdomains created problems, as it was already in use in that block.

Without this tweak, the data.processing module crashes during data import.

buckley-w-david commented 6 years ago

Whoops, good catch.

I thought I tried it out, guess I missed it