18F / rdbms-subsetter

Generates a subset of a relational database that respects foreign key constraints
Creative Commons Zero v1.0 Universal
313 stars 30 forks source link

Allow disabling write buffering via existing buffer option #28

Closed brki closed 8 years ago

brki commented 8 years ago

This fixes the issue reported in #27

I suspect the problem of #27 occurs because no row insertion dependency is considered in the flush() method. That could be fairly complex to resolve, it seems to me.

Not using write buffering at all, which this commit allows, certainly slows down the process a bit, but it does allow the subset extraction to work for tangled database relationships. Better slow and complete than broken :).

By the way, thanks for writing this! It's very helpful!

jmcarp commented 8 years ago

This looks reasonable to me. Thoughts @catherinedevlin?

catherinedevlin commented 8 years ago

Thanks for the contribution!