18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

Schedule standups by day #100

Closed mgwalker closed 7 years ago

mgwalker commented 7 years ago

Standups can be scheduled by day:

@standup-bot create standup 11:30am M W F

Totally optional - if you don't specify days, it'll do all weekdays. Includes a database migration that might or might not work, depending on how the database was setup in the first place, but we can fix that.

Closes #85.

adborden commented 7 years ago

This is awesome, I'm very much looking forward to this feature!

suprenant commented 7 years ago

Same, this will be a very useful feature for our cloud.gov team

mgwalker commented 7 years ago

Doesn't display the days when responding to the when command.

mgwalker commented 7 years ago

Aside from the failing tests, fixed in #105, this one is ready to go.

mgwalker commented 7 years ago

I think switching to a bitfield would add too much complexity around a relatively simple task. It's not a LOT of complexity, but it's new complexity that doesn't seem to add much right now.

codecov-io commented 7 years ago

Current coverage is 87.41% (diff: 96.36%)

Merging #100 into develop will increase coverage by 0.34%

@@            develop       #100   diff @@
==========================================
  Files            42         42          
  Lines          1098       1144    +46   
  Methods         208        217     +9   
  Messages          0          0          
  Branches        159        167     +8   
==========================================
+ Hits            956       1000    +44   
- Misses          142        144     +2   
  Partials          0          0          

Powered by Codecov. Last update 7023fda...b21587f