search

18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

docker and docker-compose support #102

Closed electricjesus closed 7 years ago

electricjesus commented 7 years ago

Added docker and docker-compose support. Details are in documentation/installation.md

If you have docker and docker-compose, you can now simply use docker-compose up -d to start everything.

electricjesus commented 7 years ago

Apparently the test still thinks in EDT but the helper is barfing out EST. Any plans to fix that?

stvnrlly commented 7 years ago

Thanks, @electricjesus! On a first glance, this looks 👍 . We found out about the EDT/EST thing when daylight savings time happened recently, and it's on our list of things to check out (though I notice that there's no issue for it yet).

We'll test things out a little more thoroughly shortly, and let you know if we have any other feedback.

mgwalker commented 7 years ago

On the broken tests, see #105. It's a hack, but it'll get us through until we actually fix our DST handling. :)

codecov-io commented 7 years ago

Current coverage is 85.16% (diff: 100%)

Merging #102 into develop will decrease coverage by 1.90%

@@            develop       #102   diff @@
==========================================
  Files            42         43     +1   
  Lines          1098       1213   +115   
  Methods         208        221    +13   
  Messages          0          0          
  Branches        157        170    +13   
==========================================
+ Hits            956       1033    +77   
- Misses          142        180    +38   
  Partials          0          0

Powered by Codecov. Last update a3d34a2...36c6e46

stvnrlly commented 7 years ago

@electricjesus Hey there, while we're able to get the bot up and running without any issue, we're having trouble making the site accessible. It may just be that we're not as well versed in docker-compose as we should be, but are you able to access the documentation site from outside the container?

mgwalker commented 7 years ago

That PR is open now: https://github.com/vishnubob/wait-for-it/pull/24

Since it might be a while before the maintainer can review and/or accept that PR, can we switch to using the 18F fork for now? https://github.com/18F/wait-for-it It has the environment fixes in it.

qLb commented 7 years ago

just a thumbs up on your docker-compose expose option - it makes the composition more reliable in production env since every docker reverse proxy i've checked so far uses it to pass service configuration to the discovery agent and based on this exposes the service to the outside world. cheers

electricjesus commented 7 years ago

Hey all! sorry for the late reply. I was out for the holidays :) I will be home in a few hours and I will catch up by then. Cheers for all the great feedback!

mgwalker commented 7 years ago

@qLb Ah, thanks for the info!

electricjesus commented 7 years ago

@mgwalker I think the 18F fork of wait-for-it is excellent! It's not likely going to be merged anytime soon because the original wait-for-it author cannot maintain it anymore apparently. Let's use the 18F fork, I'll put it in this PR.