18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

Environment and deploy things #104

Closed mgwalker closed 7 years ago

mgwalker commented 7 years ago

Moved cf environment handling into a separate module and added a list of expected environment variable names that will get moved over to process.env. Outside of the env.js module, all expected variables should be accessible via process.env[var_name].

Also added a "migration" create the initial database structure. This is only useful when standing the bot up for the first time, but that's a handy time not to blow up.

codecov-io commented 7 years ago

Current coverage is 88.33% (diff: 100%)

Merging #104 into develop will not change coverage

@@            develop       #104   diff @@
==========================================
  Files            42         42          
  Lines          1174       1174          
  Methods         217        217          
  Messages          0          0          
  Branches        167        167          
==========================================
  Hits           1037       1037          
  Misses          137        137          
  Partials          0          0          

Powered by Codecov. Last update 46b2052...e147855

stvnrlly commented 7 years ago

Should the new TIMEZONE get added to the known list before merging? Or maybe resolving the merge conflict will take care of that.

mgwalker commented 7 years ago

Good catch. I'll rebase on development and fix.