search

18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

Add Dockerfile to project #133

Closed kruppel closed 7 years ago

kruppel commented 7 years ago

We run standup-slack-bot as a Docker container, so it's useful to have the Dockerfile as part of the project.

codecov-io commented 7 years ago

Codecov Report

Merging #133 into develop will increase coverage by 1.43%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #133      +/-   ##
===========================================
+ Coverage    84.85%   86.29%   +1.43%     
===========================================
  Files           56       56              
  Lines         1321     1321              
  Branches       174      174              
===========================================
+ Hits          1121     1140      +19     
+ Misses         200      181      -19
Impacted Files Coverage Δ
lib/helpers/doBlock.js 93.33% <0%> (+1.66%) :arrow_up:
lib/helpers/doChannelReport.js 100% <0%> (+5.26%) :arrow_up:
lib/helpers/updateChannelReport.js 85% <0%> (+65%) :arrow_up:
lib/helpers/reports/forChannelUpdate.js 100% <0%> (+66.66%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 244f494...35740c4. Read the comment docs.

mgwalker commented 7 years ago

Hi there! We run the bot in Docker in development only - in production, it's deployed into a CloudFoundry instance. So, in general, setting the NODE_ENV env var is (potentially) problematic for us. Also, the wait-for-it script is necessary because the bot needs the database to be active from the moment it starts up - when starting up with docker-compose, there's no guarantee that the database will be ready when the bot container starts. Finally, the .env file has to be restricted from the repo lest we accidentally spill some secrets. 🙂

Thank you for the contribution, though! I'm going to fiddle with our own docker stuff to see if I can streamline it a bit. That said, I wonder if what you really want is another repo just for the Dockerfile - that file could clone the repo and do all the setup. Then you could use that as the basis for your containers.