search

18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

Only respond to emoji in channels with standups #146

Closed mgwalker closed 7 years ago

mgwalker commented 7 years ago

When the bot gets an emoji, first make sure that there's a standup in that channel. If not, don't do anything. I originally made it ignore non-public channels, but that'd be an extra wrinkle for #82 somewhere down the road, plus group DM channel IDs can start with a C, just like public channels, so... 🤷‍♀️

Closes #131

mgwalker commented 7 years ago

That first CircleCI failure was me trying to be clever with the CircleCI API. I'm not as clever as I hoped.

codecov-io commented 7 years ago

Codecov Report

Merging #146 into develop will increase coverage by <.01%. The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #146      +/-   ##
===========================================
+ Coverage    85.12%   85.13%   +<.01%     
===========================================
  Files           58       58              
  Lines         1365     1372       +7     
  Branches       179      181       +2     
===========================================
+ Hits          1162     1168       +6     
- Misses         203      204       +1
Impacted Files Coverage Δ
lib/bot/startDmEmoji.js 100% <100%> (ø) :arrow_up:
features/steps/start-dm-emoji.js 100% <100%> (ø) :arrow_up:
features/steps/common.js 84.84% <87.5%> (+0.23%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c4371a...d2fbfb1. Read the comment docs.