search

18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

Switch to eslint #148

Open mgwalker opened 7 years ago

mgwalker commented 7 years ago

This PR switches to eslint from jshint, adopts (most of) the 18F standard (eslint-config-airbnb, and fixes all the linter errors.

It's... big.

codecov-io commented 7 years ago

Codecov Report

Merging #148 into develop will increase coverage by 1.28%. The diff coverage is 89.94%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #148      +/-   ##
===========================================
+ Coverage    85.13%   86.41%   +1.28%     
===========================================
  Files           58       58              
  Lines         1372     1318      -54     
  Branches       181      182       +1     
===========================================
- Hits          1168     1139      -29     
+ Misses         204      179      -25
Impacted Files Coverage Δ
lib/helpers/reports/transformers/index.js 92.85% <ø> (ø) :arrow_up:
lib/bot/setOutOfOffice.js 19.51% <0%> (-1.01%) :arrow_down:
lib/bot/respondToUnhandledDM.js 50% <0%> (ø) :arrow_up:
lib/bot/joinChannel.js 100% <100%> (ø) :arrow_up:
lib/helpers/reports/convertStandups.js 100% <100%> (ø) :arrow_up:
features/support/setup.js 100% <100%> (ø) :arrow_up:
lib/bot/removeStandup.js 100% <100%> (ø) :arrow_up:
features/steps/set-reminder.js 100% <100%> (ø) :arrow_up:
lib/bot/startInterview.js 100% <100%> (ø) :arrow_up:
lib/bot/replyToBadStandup.js 100% <100%> (ø) :arrow_up:
... and 49 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 51556d2...d1ef21d. Read the comment docs.