search

18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

Orchestrate workflow so deploy comes AFTER tests #149

Closed mgwalker closed 7 years ago

mgwalker commented 7 years ago

As is, testing and deploying are independent, so a deploy can happen before tests. That's bad. Make deploys depend on successful tests.

codecov-io commented 7 years ago

Codecov Report

Merging #149 into develop will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #149   +/-   ##
========================================
  Coverage    85.12%   85.12%           
========================================
  Files           58       58           
  Lines         1365     1365           
  Branches       179      179           
========================================
  Hits          1162     1162           
  Misses         203      203

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e7adb6a...c19cfe4. Read the comment docs.