search

18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

Add Client Signing Secret to verify messages to bot come from Slack #156

Closed billneff79 closed 5 years ago

codecov-io commented 5 years ago

Codecov Report

Merging #156 into develop will decrease coverage by 1.29%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #156     +/-   ##
==========================================
- Coverage    86.44%   85.15%   -1.3%     
==========================================
  Files           58       59      +1     
  Lines         1372     1374      +2     
  Branches       181      181             
==========================================
- Hits          1186     1170     -16     
- Misses         186      204     +18
Impacted Files Coverage Δ
lib/helpers/reports/forChannelUpdate.js 33.33% <0%> (-66.67%) :arrow_down:
lib/helpers/updateChannelReport.js 19.04% <0%> (-57.15%) :arrow_down:
lib/helpers/doChannelReport.js 94.73% <0%> (-5.27%) :arrow_down:
lib/helpers/doBlock.js 91.66% <0%> (-1.67%) :arrow_down:
models/index.js 92.85% <0%> (ø)
lib/helpers/reports/transformers/index.js 100% <0%> (+7.14%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c8b97a...9e2a63f. Read the comment docs.

billneff79 commented 5 years ago

Looks like the version of the slack adapter for botkit that is being used by this project doesn't use the client signing secret (but does use the verification token). Closing this PR.