search

18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

Tests for getStandupInfo and giveHelp #37

Closed mgwalker closed 8 years ago

mgwalker commented 8 years ago

Saying @standup-bot time (or @standup-bot standup time) in a channel with a scheduled standup will get the bot to tell when it will report next. E.g.:

User: @standup-bot time Bot: The next standup is scheduled for 9:30 am EST tomorrow

Only supports direct mentions in an active channel, not DMs.

codecov-io commented 8 years ago

Current coverage is 97.83%

Merging #37 into develop will increase coverage by +3.30% as of df52073

@@            develop     #37   diff @@
=======================================
  Files            12      12       
  Stmts           183     185     +2
  Branches         22      22       
  Methods           0       0       
=======================================
+ Hit             173     181     +8
  Partial           2       2       
+ Missed            8       2     -6

Review entire Coverage Diff as of df52073

Powered by Codecov. Updated on successful CI builds.

mgwalker commented 8 years ago

Didn't see #38, which looks like it covers the same ground with a more user-friendly interaction. Pulling the "standup check" part from that branch and updating the tests would be easy. Might be best of both worlds?

I also see where the time.getDisplayFormat() needs a little bit of self-protection. It expects a moment object. It should be able to take a moment object, a number, of a Number-able string.

mgwalker commented 8 years ago

Resolved conflict by merging #38. This PR is now just adding tests.