search

18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

Report real names #40

Closed mgwalker closed 8 years ago

mgwalker commented 8 years ago

Adds two new helpers. One gets full user info from the Slack web API and caches it, the other builds up a report object so we can use the same thing in multiple places.

The Standup model is modified to include userRealName, which corresponds to the real_name property returned from Slack. This is the value present at the time the standup is recorded.

The getStandupReport helper is pulled entirely from the standup reporter. Instead of displaying Slack username links in the standup report, it now shows users' real names, as self-defined in Slack.

The standup reporter is modified to use the getStandupReport helper.

The user standup info collector thingy is modified to get the user's full info from Slack and store their real name in the database. It is also modified to use the getStandupReport helper to more accurately reflect what will be reported.

Tests for all of the above.

codecov-io commented 8 years ago

Current coverage is 98.14%

Merging #40 into develop will increase coverage by +0.22% as of 729e49b

@@            develop     #40   diff @@
=======================================
  Files            12      14     +2
  Stmts           193     216    +23
  Branches         23      27     +4
  Methods           0       0       
=======================================
+ Hit             189     212    +23
  Partial           2       2       
  Missed            2       2

Review entire Coverage Diff as of 729e49b

Powered by Codecov. Updated on successful CI builds.

stvnrlly commented 8 years ago

:+1: