18F / standup-slack-bot

A Slack bot to streamline team standup without disturbing the overall flow of conversation
https://standup-slack-bot.app.cloud.gov/
Other
87 stars 31 forks source link

58 edit interview responses #74

Closed mgwalker closed 8 years ago

mgwalker commented 8 years ago

Allow users to edit interview responses. Based on this user story:

Scenario: Edit a interview answer

Given a completed interview And a category that has an answer or not When the standupper writes standup [channel] edit [category] Then standup-bot asks the interview question again And provides the previous answer And the standupper can provide a new answer And the new answer is recorded.

screen shot 2016-05-18 at 3 05 07 pm

Also adds a response from the bot when it is updating an existing report, so the user gets some kind of feedback.

screen shot 2016-05-18 at 3 06 31 pm

Closes #58.

codecov-io commented 8 years ago

Current coverage is 82.81%

Merging #74 into develop will decrease coverage by 0.16%

@@            develop        #74   diff @@
==========================================
  Files            24         24          
  Lines           541        570    +29   
  Methods          95        100     +5   
  Messages          0          0          
  Branches         79         89    +10   
==========================================
+ Hits            449        472    +23   
- Misses           92         98     +6   
  Partials          0          0          

Powered by Codecov. Last updated by 7b03aa9...f0701d5

stvnrlly commented 8 years ago

How would you feel about using an array of callbacks instead of conditionals? That seems to be what botkit recommends: https://github.com/howdyai/botkit#using-conversationask-with-an-array-of-callbacks. Also note the bot.utterances thing in there, which could be good to grab, as well.

mgwalker commented 8 years ago

Uses utterances and an array of callbacks now. Unfortunately there's still some conditional logic in there to determine what to say first and a promise to control whether the main body of the conversation happens or not.

stvnrlly commented 8 years ago

LGTM!