Add additional utilization tests for common business cases

18F / tock

We use Tock to track and report our time at 18F

https://18f.gsa.gov/2015/05/21/TockingTime/

Other

121 stars 37 forks source link

Add additional utilization tests for common business cases #1610

Closed kingcomma closed 1 year ago

kingcomma commented 1 year ago

Description

Adds additional utilization tests for common business cases:

Timecard with many weekly billing projects (e.g., an AM)
Timecards with 40 hours of out of office time
Timecards with billable expectations < .8

Closes #1607

codecov-commenter commented 1 year ago

Codecov Report

Merging #1610 (671a4d6) into main (2ec7d38) will increase coverage by 0.08%. The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1610      +/-   ##
==========================================
+ Coverage   93.98%   94.06%   +0.08%     
==========================================
  Files          66       66              
  Lines        4023     4080      +57     
==========================================
+ Hits         3781     3838      +57     
  Misses        242      242

see 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

jduss4 commented 1 year ago

This looks great! I am so glad that the OOO + weekly allocation test works out without needing any more changes to the timecard model!

kingcomma commented 1 year ago

@cantsin I marked this as ready for review and haven't changed anything since your approval. I was going to try and squeeze in some alternative work schedule tests to this PR, but I think that will take a little longer than I expected and just hold this work up. I'm 👍 if you're 👍 .