18F / tock

We use Tock to track and report our time at 18F
https://18f.gsa.gov/2015/05/21/TockingTime/
Other
120 stars 37 forks source link

upgrade jest-puppeteer and puppeteer manually #1712

Closed cantsin closed 5 months ago

cantsin commented 7 months ago

Description

Fixing a dependabot PR manually: https://github.com/18F/tock/pull/1711

The issue is that builds fail if we upgrade jest-puppeteer by itself:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: jest-puppeteer@9.0.2
npm ERR! Found: puppeteer@13.7.0
npm ERR! node_modules/puppeteer
npm ERR!   dev puppeteer@"^13.7.0" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer puppeteer@">=19" from jest-puppeteer@9.0.2
npm ERR! node_modules/jest-puppeteer
npm ERR!   dev jest-puppeteer@"^9.0.2" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: puppeteer@21.7.0
npm ERR! node_modules/puppeteer
npm ERR!   peer puppeteer@">=19" from jest-puppeteer@9.0.2
npm ERR!   node_modules/jest-puppeteer
npm ERR!     dev jest-puppeteer@"^9.0.2" from the root project

So here, I've upgraded puppeteer manually as well.

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2bcddb1) 94.15% compared to head (e17c443) 94.15%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1712 +/- ## ======================================= Coverage 94.15% 94.15% ======================================= Files 66 66 Lines 4156 4156 ======================================= Hits 3913 3913 Misses 243 243 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.