18F / tock

We use Tock to track and report our time at 18F
https://18f.gsa.gov/2015/05/21/TockingTime/
Other
120 stars 37 forks source link

Allow zero for project allocation on hourly projects #1730

Closed neilmb closed 4 months ago

neilmb commented 4 months ago

Description

1728 was tracked down to a situation where the timecard form might submit "0" for project allocation even for hourly billing projects. This changes the form cleaning code to allow that possibility without raising the error message from the bug.

We add a test for the situation that fails in our current code and passes with the fix.

Additional information

There are a couple unrelated changes where or None was removed where it wasn't doing anything.

Fixes #1728