18F / tock

We use Tock to track and report our time at 18F
https://18f.gsa.gov/2015/05/21/TockingTime/
Other
121 stars 37 forks source link

Harden integration testing #1822

Open nateborr opened 1 day ago

nateborr commented 1 day ago

Investigate and choose an approach to harden Tock's browser-based integration testing, to minimize errors and toil due to library updates and changes in third-party platforms. If changes would be helpful, either implement them or open an issue to do that work as a follow-up.

Updating Puppeteer from version 19.11.1 to 23.6 for #1796 required some changes to keep the Jest/Puppeteer based integration tests running both in CircleCI and in a local Docker environment. These changes are working, but they've introduced some brittle elements:

The relevant code changes were introduced in PR #1819. That PR's description includes additional technical context.

Some paths to consider:

cantsin commented 1 day ago

Excellent write up, thank you! Another thing we can consider is moving away from CircleCI entirely. I don't like that we are seeing discrepancy between local and CI tests. But that will require some compliance document changes as well. For now, let's sit on this. Thanks again!

nateborr commented 1 day ago

Thanks @cantsin , I've updated the issue description accordingly along with some context on our CircleCI setup.