search

18F / uswds-jekyll

A Jekyll theme showcasing the U.S. Web Design System
https://federalist-proxy.app.cloud.gov/site/18f/uswds-jekyll/
Other
136 stars 120 forks source link

Empty secondary links #224

Closed dmundra closed 3 years ago

dmundra commented 3 years ago

Hi,

We are using the uswds-jekyll setup for the CivicActions accessibility site and we noticed that commenting out secondary menu items from navigation.yml generated empty links which are flagged by the Wave accessibility tool. A fix was to also comment out the secondary menu items from header.yml.

We wanted to share that and also suggest that maybe header.html could be hardened to handle empty secondary menu items. Any thoughts or suggestions?

Thank you.

A screenshot of the empty link is visible at this link https://github.com/CivicActions/accessibility/pull/90

dmundra commented 3 years ago

I think I am going to close this as in this example https://github.com/CivicActions/ca-jekyll-vanilla where I use the uswds-jekyll theme as a remote theme if we don't want the secondary menu items you have to comment it out in two places:

If you do not the link gets the value 'secondary' that generates an empty link.