18F / ux-guide

Resources, norms, and practices for doing user experience research and design work at 18F.
https://ux-guide.18f.gov
Other
76 stars 29 forks source link

Updated consent for Gdoc links #366

Closed MelissaBraxton closed 1 year ago

MelissaBraxton commented 1 year ago

This updates a link that was pointing to an archived English language version w/ a link to the current template; The link to the Spanish language gdoc was actually pointing to a deprecated consent form in google forms in English. I updated this to point to the correct Spanish language example template in Gdocs.

Description of changes

Describe what this pull request is changing. Try to use plain language as much as possible to help teammates understand what they are reviewing.

Known issues

If this pull request introduces anything that needs to be addressed later, note it here. Some examples might be if you introduced a new link that fails tests but will work when another pull request is merged; you created a new method placeholder but it does not yet have content; or your change breaks something else that will be removed later. If you create any issues to address issues created by this pull request, this is a good place to list them! You can delete this section if the PR does not introduce any new issues.

Related issues

If this pull request is associated with any other issues or pull requests, lis them here. If this PR closes an issue, list it as closes #issue so the issue will automatically be closed when the PR is merged. If there are no related issues or PRs, you can delete this section.

Reviewers:

In addition to assigning reviewers in the GitHub interface, please also list who you would like a review from here and, if applicable, what kind of review you would like from them. For example, you might ask one person to review content while someone else reviews visual layout.

github-actions[bot] commented 1 year ago

At least one link is invalid. Please check the output of the tests in the checks below. For more information, see the wiki page on automated tests.

bpdesigns commented 1 year ago

@MelissaBraxton lets chat about this issue. I think in an earlier issue we removed the google doc links from the page and added them to the participant agreement page so that people outside 18F would not get confused or try to access links meant for internal purposes.

MelissaBraxton commented 1 year ago

Sure let's chat! I wasn't adding any new links, just fixing existing links that pointed to an archived version, but if you want to remove the links to Gdocs here altogether, go for it!

github-actions[bot] commented 1 year ago

At least one link is invalid. Please check the output of the tests in the checks below. For more information, see the wiki page on automated tests.