18F / ux-guide

Resources, norms, and practices for doing user experience research and design work at 18F.
https://ux-guide.18f.gov
Other
76 stars 29 forks source link

Update application.js #370

Closed AnitaYCheng closed 1 year ago

AnitaYCheng commented 1 year ago

Switch use of # in headings to link icon like in the TTS handbook, to make the heading links accessible to screenreaders. This includes adding the SVG link icon to the application.

Description of changes

Describe what this pull request is changing. Try to use plain language as much as possible to help teammates understand what they are reviewing.

Known issues

If this pull request introduces anything that needs to be addressed later, note it here. Some examples might be if you introduced a new link that fails tests but will work when another pull request is merged; you created a new method placeholder but it does not yet have content; or your change breaks something else that will be removed later. If you create any issues to address issues created by this pull request, this is a good place to list them! You can delete this section if the PR does not introduce any new issues.

Related issues

If this pull request is associated with any other issues or pull requests, lis them here. If this PR closes an issue, list it as closes #issue so the issue will automatically be closed when the PR is merged. If there are no related issues or PRs, you can delete this section.

Reviewers:

In addition to assigning reviewers in the GitHub interface, please also list who you would like a review from here and, if applicable, what kind of review you would like from them. For example, you might ask one person to review content while someone else reviews visual layout.

MelissaBraxton commented 1 year ago

Hey @jasnakai !

Would you be up for reviewing this to see if it fixes the header issue?

Two things:

mgwalker commented 1 year ago

@AnitaYCheng If you have access to create branches directly on this repo instead of using a fork, that will make cloud.gov Pages run the build. It doesn't build PRs from forks.

@MelissaBraxton I got an email about this. I don't know why. 😂 I hope it's okay that I hopped in!

MelissaBraxton commented 1 year ago

Oh! I didn't pick up on this being a fork... Thanks @mgwalker! (And you're always welcome to hop in!)

AnitaYCheng commented 1 year ago

Duplicate PR, this was a separate branch before I was a member of the repo. #373 replaces this PR.