7.x 1.x - Githubissues

18F / web-design-standards-drupal

A Drupal base theme that uses the U.S. Web Design System. (ARCHIVED)

Other

46 stars 12 forks source link

7.x 1.x #13

Closed AlexBrown-appnovation closed 8 years ago

AlexBrown-appnovation commented 8 years ago

basic html.tpl.php page added with some customization
added meta tags found on web design standards site (mostly to do with icons and mobile optimizations)
also includes scripts for IE9 and below at the bottom of the page just inside the end of the body
updated info file with the same description as the d8 branch

fureigh commented 8 years ago

@AlexBrown-appnovation I left an inline comment, but if this is a work-in-progress branch and you'd rather I hold off, just let me know.

AlexBrown-appnovation commented 8 years ago

@fureigh the image assets should already be in this branch in the assets folder. Let me know if I'm not understanding your request properly though!

fureigh commented 8 years ago

@AlexBrown-appnovation I see these files:

favicon.ico
screenshot.png

...but not these:

favicon-72.png
favicon-114.png
favicon-144.png

...which are referenced in lines 24, 26 and 28 of templates/system/html.tpl.php. If I'm misunderstanding something, let me know.

AlexBrown-appnovation commented 8 years ago

@fureigh if you look in /assets/img/favicons/ you'll find everything in there.

fureigh commented 8 years ago

@AlexBrown-appnovation Beautiful, thanks! Will you add them to this PR?

fureigh commented 8 years ago

@AlexBrown-appnovation I can do it if you'd prefer, but I don't want to step on your toes. Also, it's usually safer to have the person who made something be the person who adds that thing.

AlexBrown-appnovation commented 8 years ago

Unless I'm mistaken, I believe the assets folder already exists in this branch! Must have been pushed up with one of my first commits!

fureigh commented 8 years ago

@AlexBrown-appnovation D'oh. You're right! Included with the USWDS assets folder. Merging away.

fureigh commented 8 years ago