search

18F / web-design-standards-drupal

A Drupal base theme that uses the U.S. Web Design System. (ARCHIVED)
Other
46 stars 12 forks source link

gulp setup #20

Closed AlexBrown-appnovation closed 8 years ago

AlexBrown-appnovation commented 8 years ago

The following PR is for our base Gulp.js setup. Our first task will be to do some basic SASS processing and output the results to the css/ directory.

The instructions for setting this up via the terminal are kept in the SASS readme file for now, but may need to be moved to a theme-level readme file in the future.

fureigh commented 8 years ago

:+1:

It's worth including instructions in the general README so contributors and anyone modifying this theme knows how to proceed. Here's one example: https://github.com/friendlymachine/atlas. Want to take a stab at that or save it for another PR?

AlexBrown-appnovation commented 8 years ago

Lets save that for another PR if you don't mind!

fureigh commented 8 years ago

Okay with me; made follow-up issue #21. Also, just noticed that this is marked wip! Didn't mean to interrupt. :)

AlexBrown-appnovation commented 8 years ago

Removed the wip (insert whip sound effect here).

Consider this ready for review - I guess my understanding of the wip branch was that it is something that could change in the future, but I guess we would just iterate upon the file in a separate PR in that case.

fureigh commented 8 years ago

:+1: Yeah, let's use separate PRs for additional work. While everything is always subject to change, I like including 'WIP' to indicate that something's an active work in progress (i.e., not yet ready for merging). See this discussion of the WIP Pattern or early pull strategy for further thoughts on that.

AlexBrown-appnovation commented 8 years ago

Thanks for those resources, never thought of opening with a PR for tracking purposes!

AlexBrown-appnovation commented 8 years ago

Just in case it wasn't apparent, this PR is good to go pending any more changes or feedback from the community.

iris-i commented 8 years ago

+1 for merging this PR @fureigh. I'm thinking of creating a new issue to also add the sourcemaps & autoprefixer plugins. I created #25

fureigh commented 8 years ago

Looks good to me! Merging.