search

18F / web-design-standards-drupal

A Drupal base theme that uses the U.S. Web Design System. (ARCHIVED)
Other
46 stars 12 forks source link

[D7] Theme tables #33

Open fureigh opened 8 years ago

fureigh commented 8 years ago

Stub.

Notes:

iris-i commented 8 years ago

Task: Confirm that tables are themed. Test with the HTML output from: https://playbook.cio.gov/designstandards/tables/

Hey @fureigh, I'm a bit unclear about the theming issues. Since we have the core sass files from the design standards playbook in the /assets/_scss folder, most of the components are already styled. I'm wondering if the theming issues are for adding template overrides/preprocess functions where necessary? And if so, does this apply to components like tables and lists?

fureigh commented 8 years ago

@iris-i Sorry to have left you hanging here! Those theming issues are essentially an expanded checklist of components to verify are styled correctly. Unless an issue includes specific technical notes, its approach hasn't yet been defined. Some components will require changes to ensure that their markup renders correctly but some work "out of the box" because of the /assets/_scss folder's contents. Where they work "out of the box," let's simply note that and (happily) close the issue.