fureigh
commented
8 years ago Thanks for this! (And thanks for your patience with the delayed review; I've been sick these past few days.)
Quick thoughts:
- +1 to opting for core module support before contributed module support.
- When possible in future issues/PRs, please post a before-and-after screenshot to clearly demonstrate the problem being addressed.
- Important: can you verify that the use of
display: nonehere doesn't adversely affect 508 compliance? See http://a11yproject.com/posts/how-to-hide-content/ for further detail.
"some simple styles that fix the core toolbar module layout that get broken by the uswds"
Currently this is just for the core toolbar module. We will probably have to do check out what is happening with the administration_menu module as well, but I opted for core module support here before contributed module support.