initial info file added which turns off nearly all default drupal CSS…

18F / web-design-standards-drupal

A Drupal base theme that uses the U.S. Web Design System. (ARCHIVED)

Other

46 stars 12 forks source link

initial info file added which turns off nearly all default drupal CSS… #6

Closed AlexBrown-appnovation closed 8 years ago

AlexBrown-appnovation commented 8 years ago

removed core CSS files (will add them back in where necessary)
removed core module CSS files (will add them back in where necessary)
added design standards CSS files
added design standards JavaScript files
created default regions (totally placeholder at the moment)

fureigh commented 8 years ago

@AlexBrown-appnovation Thanks for this! I made some inline comments. The two main changes I'd suggest are:

Change 'US' to 'U.S.' and
Change spacing to be compliant with Drupal coding standards, though I do appreciate the readability of the tab-based approach you used.

AlexBrown-appnovation commented 8 years ago

'US' has been changed to 'U.S.'
spacing around operators is now up to Drupal Standards

fureigh commented 8 years ago

@AlexBrown-appnovation :+1: Thanks! Curious to hear about the double semicolons but merging for now.

AlexBrown-appnovation commented 8 years ago

The double semi colons are just my commenting style, if its just one line being commented out I use one, but if I'm writing a block of text and keeping it within 80 characters in width I'll use two.

fureigh commented 8 years ago

Got it. For the sake of readability, where the Drupal coding standards exist, I'd ask that we generally stay in line with them.