[Feature request] Add blacklisted domains to normal configuration

[soli]

Basically I'd like to be able to sync them the same way I sync the rest of my config.

Thanks.

[wooger]

This makes sense, no reason to separate some config in a different file.

[1995eaton]

The main problem with this is that a separate textbox for the blacklists makes it a lot easier for the cVim popup to dynamically add/remove blacklists. If I were to combine these textboxes, it would most likely require a considerable amount of extra code.

[soli]

But would you consider a pull request for the merge? [I'm all optimistic right now, with a week-end ahead, but actually I have many other things to do, so no guarantee :P]

[1995eaton]

I'd definitely consider a pull request if you can get it working! The relevant files you'd have to look into would be background_scripts/popup.js, content_scripts/command.js (lines 621-643), and pages/options.js

[soli]

I have a question (not directly related, but…): checkBlackList from command.js now uses matchLocation but getBlacklisted and toggleBlacklisted from popup.js don't

Since I was playing around with that code, I'd like to know what to do…

• I suppose you don't want matchLocation for toggling, since you could toggle a whole family of domains instead of just one
• but the result is that currently, the button icon color and popup text might be incoherent (I never noticed before since I don't normally use the button)

Should I just leave all this as is, and just care about the main objective of moving the blacklists into normal settings or should we solve both altogether? [I'd say, use matchLocation everywhere, even if enabling a single site of a glob pattern would enable the whole pattern…]