1995eaton / chromium-vim

Vim bindings for Google Chrome.
https://chrome.google.com/webstore/detail/cvim/ihlenndgcmojhcghmfjfneahoeklbjjh
MIT License
2.25k stars 325 forks source link

Quickmarks/Search broken (take III- the revenge off.. ;-) ) #42

Closed zeltak closed 10 years ago

zeltak commented 10 years ago

Hya :)

quick marks and searches are broken again here

for single quickmarks they do work but dont launch the site but rather a google search same for seach engines...it launches a google search quickmark multiple quickmark (for multiple sites) seem completely broken (maybe my syntax is wrong? though i followed the docu)

here is my current relevant section:

"Quick marks

let qmark 0 = "http=//www.weather.com/weather/today/Chestnut+Hill+MA+02467" let qmark 1 = "https=//mail.google.com/mail/u/0/?tab=cm&zx=1a9kkuzmcil0m&shva=1#inbox" let qmark 2 = "https=//ttrss.server-speed.net/#f=-3am" let qmark 3 = "https=//www.google.com/calendar/b/0/render?tab=mc"

let qmark 5 = "https=//www.google.com/contacts/#contacts

let qmark 6 = ["http=//woot.com" ,"http=//1saleaday.com/" , "http=//mobile.dailysteals.com/" , "http=//slickdeals.net/", "http=//www.priceplunge.com/" , "http=//www.amazon.com/mobile-apps/b?ie=UTF8&node=2350149011" , "http=//deals.woot.com/"]

let qmark 7 = ["https=//groups.google.com/forum/?fromgroups=#!forum/", "https=//plus.google.com/u/0/", "https=//bbs.archlinux.org/viewforum.php?id=27"]

let qmark 9 = ["http=//www.walla.co.il/", "http=//www.ynet.co.il/", "http=//www.nrg.co.il/", "http=//sports.walla.co.il/", "http=//espn.go.com/", "http=//soccernet.espn.go.com/", "http=//www.cnn.com/", "http=//kde-apps.org/", "http=//kde-look.org/", "w"="http=//www.walla.co.il/"]

let qmark o = "http=//sports.walla.co.il/" let qmark e = "http=//espn.go.com/" let qmark s = "http=//soccernet.espn.go.com/?cc=5901" let qmark c = "http=//www.cnn.com/" let qmark l = "http=//www.livescore.com/default.dll?page=home" let qmark L = "http=//www.firstrowsports.eu/"
let qmark S = "http=//subforge.org/projects/subtle/wiki" let qmark E = "http=//espn.go.com/espn3/index" let qmark P = "http=//paste.xinu.at/"
let qmark Y = "http=//picasaweb.google.com/ykloog" let qmark d = "http=//debuzzer.com/"
let qmark R = "https=//bbs.archlinux.org/viewtopic.php?pid=875820#p875820" let qmark F = "http=//192.168.0.44/" let qmark D = "http=//www.dropbox.com/" let qmark W = "192.168.0.100" let qmark M = "http=//www.nrg.co.il/online/55/ART2/334/648.html?hp=55&cat=302&loc=11" let qmark m = "http=//talk.maemo.org/" let qmark a = "http=//forum.mobilism.org/viewforum.php?f=398&sid=458ecb73421dcafe102bc23ef5f955fe" let qmark q = "http=//slickdeals.net/" let qmark x = "http=//forum.xbmc.org/" let qmark h = "http=//www.haaretz.co.il/" let qmark U = "http=//gmusicbrowser.org/layout_doc.html" let qmark i = "http=//boston.craigslist.org/" let qmark K = "http=//livetv.ru/en/" let qmark f = "https=//bbs.archlinux.org/viewforum.php?id=27" let qmark g = "https=//plus.google.com/u/0/" let qmark y = "www.ynet.co.il"
let qmark r = "http=//lists.gnu.org/archive/html/emacs-orgmode/"
let qmark u = "https=//github.com/zeltak"
let qmark v = "https=//vpn.bgu.ac.il/extender.html"

"internal chrome marks let qmark x = :chrome://extensions

" Search engines let searchengine im = "http://www.imdb.com/find?q=%s&s=all"

1995eaton commented 10 years ago

I'm seeing a couple of syntax errors in your config (e.g. qmark x would be "chrome://extensions", qmark 9 has an equal sign instead of a comma: "w"="http=//www.walla.co.il/", and qmark 5 is missing a quotation mark)

Also, http= isn't a valid URL. I think you mean http:

zeltak commented 10 years ago

Thx that fixed most of the issues but not multiple quikmark. is this still wrong somehow:

let qmark 9 = ["http://www.walla.co.il/", "http://www.ynet.co.il/", "http://www.nrg.co.il/", "http://sports.walla.co.il/", "http://espn.go.com/", "http://soccernet.espn.go.com/", "http://www.cnn.com/", "http://kde-apps.org/", "http://kde-look.org/"]

best

z

1995eaton commented 10 years ago

This most recent commit should fix all issues with quickmarks. Please test it out before I push the update to the Chrome store and let me know how it works. Just download the project as a zip file (https://github.com/1995eaton/chromium-vim/archive/master.zip), go to chrome://extensions, check the developer mode box, and click load unpacked extension (direct it to the unzipped folder). Just make sure to disable the Chrome store cVim so no conflicts occur.

zeltak commented 10 years ago

Hya

good thing we checked ;-) the numric quickmark work well now (even the multi link quicmark) but the alpha ones stopped working for some reason ie "w" ,"y" etc. one note is that alpha quickmark to chrome extensions do work, ie:

let qmark x = "chrome://extensions"

but this dosed not work

let qmark u = "https://github.com/zeltak"

ill be happy to help testing as needed

best

Z

1995eaton commented 10 years ago

They seem to work fine here. Have you tried restarting chrome or refreshing the pages after saving the config?

zeltak commented 10 years ago

hya. yeah restarted chrome twice. as i said everything works apart from these quickmarks that start with an alpha character and point to links (it gives the quickmark not found error)

here is my full config:

https://gist.github.com/zeltak/287a9f894d3c06a7568a

also im running chromium Version 35.0.1916.114 (270117) on arch linux

best

Z

1995eaton commented 10 years ago

I see where I made a mistake. It should be fixed now.

zeltak commented 10 years ago

Hi, the master zip file you posted before for manual install seems to be not updated so i cant test it. let me know if you want me to test this (and any other issues) before you push it to the google store

z

1995eaton commented 10 years ago

You just have to download the zip from https://github.com/1995eaton/chromium-vim/archive/master.zip again, uninstall the last extension, and install this one (or you could unzip the new master.zip into the old directory, replacing the previous contents). Let me know if this fixes the quickmark issues. Thanks

zeltak commented 10 years ago

Hya

yup all works now :) thx alot!

Z