search

1995eaton / chromium-vim

Vim bindings for Google Chrome.
https://chrome.google.com/webstore/detail/cvim/ihlenndgcmojhcghmfjfneahoeklbjjh
MIT License
2.26k stars 325 forks source link

Callback is always firing every 10ms on 1.2.83 #440

Closed rhysd closed 8 years ago

rhysd commented 8 years ago

Hi, thank you for great extension 😄

After v1.2.83, cVim always consumes CPU at the foreground page. I tried profiling the page with DevTools' timeline feature, then I found that it fires a callback every 10ms.

2016-04-21 16 42 17

And I found the timer code.

https://github.com/1995eaton/chromium-vim/blob/2f89d1a99cf5b7977d1a59e79ad2012174fdf6c0/content_scripts/command.js#L1034

This is already removed on the HEAD of this repository and it looks to resolve this issue. So I'll be happy if next version is released as soon as possible :pray:

1995eaton commented 8 years ago

Just published 1.2.84 to the Chrome store. The update should be available in around an hour

rhysd commented 8 years ago

Thanks! :+1: