search

1995eaton / chromium-vim

Vim bindings for Google Chrome.
https://chrome.google.com/webstore/detail/cvim/ihlenndgcmojhcghmfjfneahoeklbjjh
MIT License
2.25k stars 326 forks source link

Updated creating a shadow root to use Shadow DOM v1 spec. This fixes … #719

Open antonioyon opened 4 years ago

antonioyon commented 4 years ago

…the broken hints functionality as of Chrome 80.0.3955.4.

Chrome 80.0.3955.4 and beyond follows v1 of the Shadow DOM spec. The element.createShadowRoot() function has been deprecated and replaced with element.attachShadow({ mode: 'open' }) for an open shadow root.

Fixes #716

antonioyon commented 4 years ago

Also fixed an indent issue on lines 40-42

eyaleizenberg commented 4 years ago

@njohnson7 Any chance to merge and upload new version?

njohnson7 commented 4 years ago

@njohnson7 Any chance to merge and upload new version?

Sorry I don't have write access...

ShawnConn commented 4 years ago

Looks good here. Thanks, @antonioyon!

dcchambers commented 4 years ago

Thanks for the fix @antonioyon! Installed manually and works perfectly.

Is there any indication that this will get merged? No updates to this project since November of 2017. Without this fix one of the main aspects of the extension is broken, rendering it pretty useless.

eyaleizenberg commented 4 years ago

I installed manually but it's not working for me. Using Chrome 80.0.3987.87

antoniobusrod commented 4 years ago

@eyaleizenberg

I installed manually but it's not working for me. Using Chrome 80.0.3987.87

Fast check, have you installed from issue-716-fix-broken-hints branch?

andrewpsy commented 4 years ago

Can someone has permission get this fix merged and released? Thanks.

ShawnConn commented 4 years ago

See #723

dcchambers commented 4 years ago

Hi @antonioyon - merged your branch into my fork here: https://github.com/dcchambers/vb4c

Working on getting a fixed version uploaded to the Chrome web store now...