1995eaton / chromium-vim

Vim bindings for Google Chrome.
https://chrome.google.com/webstore/detail/cvim/ihlenndgcmojhcghmfjfneahoeklbjjh
MIT License
2.25k stars 326 forks source link

'f' stopped working in most recent versions of Chrome #726

Open geg-mopo3 opened 4 years ago

geg-mopo3 commented 4 years ago

After recent updates of Chrome 'f' key stopped working. Links don't get highlighted and numerated after pressing the key.

My current version is: Version 80.0.3987.100 (Official Build) (64-bit)

artem-nefedov commented 4 years ago

Not just f, but also q, mf, and so on - anything that requires highlighting.

artem-nefedov commented 4 years ago

Weirdly, it does work on YouTube for me, but not on other sites.

robin521111 commented 4 years ago

it doesn't work from my chrome as well, f. here is the version what i using.

Version 80.0.3987.100 (Official Build) (64-bit)

without f function that's quite complicated for me.

stefanjacobs commented 4 years ago

Same here. With Chrome Version 80.0.3987.106 (Offizieller Build) (64-Bit) only YouTube is working with f - no other page works.

vmakarenko commented 4 years ago

Same to me for cVim: 1.2.99 Chrome version 80.0.3987.106 (Official Build) (64-bit), Ubuntu

dany74q commented 4 years ago

See @dcchambers fork here

Side note: I've migrated to use the 'vimium' extension - it provides an equivalent set of functionality and seems to be more actively maintained.

Linkandzelda commented 4 years ago

Press f to pay respects.

Just kidding, wanted to say this is happening for me too on Arch Linux Chromium 80.0.3987.87 (Official Build)

dcchambers commented 4 years ago

The latest version of chrome broke this because it deprecated Element.createShadowRoot. A fix has been submitted but has not been merged. For now you'll have to manually install the fix. Instructions here.

We're discussing the posibility of forking this into a maintained project as right now this project appears to no longer be maintained. See discussion here: #723

This is a dup of: #716 For a fix, see PR #719 or #724

robin521111 commented 4 years ago

image lucky me, i just debug the code and solved this issue with just one line of code.

DavidGretzschel commented 4 years ago

@robin521111 would you mind sharing how to do that?

chougousui commented 4 years ago

@DavidGretzschel check #724 and click on the link "832c0b6", at line 727. good luck

Vxider commented 4 years ago

Same here, waiting for update

artem-nefedov commented 4 years ago

Same here, waiting for update

Don't expect an update any time soon - this project is abandoned

Vxider commented 4 years ago

Same here, waiting for update

Don't expect an update any time soon - this project is abandoned

Do you have any other recommendations?

Vxider commented 4 years ago

Have already uninstall cVim...

dcchambers commented 4 years ago

Hey @Vxider!

Here's your options right now:

1) Manually install the fixed version following these instructions: https://github.com/1995eaton/chromium-vim/issues/716#issuecomment-583425260 2) Try a different extension like vimium which is actively maintained 3) Hold on a few more days. This weekend I am going to fork this project and take a look through the code, patch the fixes in, and release a new version on the web store to download/install automatically.

Vxider commented 4 years ago

Hey @Vxider!

Here's your options right now:

  1. Manually install the fixed version following these instructions: #716 (comment)
  2. Try a different extension like vimium which is actively maintained
  3. Hold on a few more days. This weekend I am going to fork this project and take a look through the code, patch the fixes in, and release a new version on the web store to download/install automatically.

Thank you for your work. waiting for your update.👍

akai1831 commented 4 years ago

Guys, please have a look on SurfingKeys as alternative, it is actively maintained by Developer.

Kind regards, Red

robin521111 commented 4 years ago

@robin521111 would you mind sharing how to do that?

sorry for late reply, you just need go to my folk then download the code and load it as an extension at developer mode. the steps as follow:

  1. copy or clone the code from below link.
  2. open extension feature in your chrome and remove existing cvim
  3. load the source code from your copy and update it.
  4. sure you can also pack it if you don't want open developer mode all the time. https://github.com/robin521111/chromium-vim
robin521111 commented 4 years ago

it works very good in my another windows version of chrome. image image

imcoddy commented 4 years ago

Any chance we have a updated version? The chrome just becomes quite difficult to use after the update :(

fow5040 commented 4 years ago

For anyone else that goes to this thread - dcchambers plans on forking and maintaining cvim in both his Chrome repo and as a new Chrome Extension (vb4c), please see the Issue #423 Thread for reference!

dcchambers commented 4 years ago

Thanks for the mention @fow5040 - the extension has been submitted to the play store but is still pending review/approval from Google. Hopefully it will get approved soon.

For anyone looking for a fix - check out the repo here: https://github.com/dcchambers/vb4c - I will post an update once the extension is approved and listed in the store. In the mean time, you can follow the instructions in the readme to install it manually. Cheers!

dadiorchen commented 4 years ago

@dcchambers why Google holds on the approval? This function is so important to me...

dosentmatter commented 4 years ago

You guys can use both cvim and vimium at the same time by unmapping everything except f from vimium.

After installing vimium, right click vimium extension icon > options > paste following in "Custom key mappings" > "Save Changes"

# Insert your preferred key mappings here.
unmapAll
map f LinkHints.activateMode
map F LinkHints.activateModeToOpenInNewTab
artem-nefedov commented 4 years ago

@dosentmatter That's a neat idea. What about mf (selecting multiple links)? I checked vimium docs, and that seems to be Alt+f shortcut.

Edit: Nvm, I figured it out:

map mf LinkHints.activateModeWithQueue

So yeah, this is definitely usable. However, one thing to note is that Vimium creates hints with key sequences from both sides of keyboard, so they require both hands to press, while hints created by cVim only use left side of keyboard, and can always be pressed with one hand.

dosentmatter commented 4 years ago

@artem-nefedov, another problem with my vimium workaround is that vimium doesn't obey cvim's insert mode. So f will also work in insert mode. However, vimium does have rules to disable it for sites matching some pattern or you can just disable vimium entirely.

artem-nefedov commented 4 years ago

BTW, did anyone figure out why cVim links still work on YouTube? And, is there a possibility to "patch" other sites on load (e.g. with custom tampermoney script) to "implement" missing function? I'm not much of a frontend guy myself to understand this.

pushkin- commented 3 years ago

I just reinstalled the extension and now F works for me? I'm on Chrome 89.

dcchambers commented 3 years ago

@pushkin- it appears that the author of the plugin has pushed a fix to the version in the app store to resolve that issue, but hasn't updated the application on github.

See: https://github.com/1995eaton/chromium-vim/issues/716#issuecomment-809001658