search

199ocero / activity-timeline

Add timelines to custom pages or infolist entries effortlessly. Plus, it teams up smoothly with Spatie Activitylog for easy tracking.
https://filamentphp.com/plugins/jaocero-activity-timeline
MIT License
65 stars 18 forks source link

[Bug]: icon will overlap with the close button #11

Closed hanaexcl closed 10 months ago

hanaexcl commented 10 months ago

What happened?

It'll overlap with the close button.

螢幕擷取畫面 2024-01-19 031042

How to reproduce the bug

Using ViewAction in slideOver mode.

Tables\Actions\ViewAction::make()->slideOver(),

Package Version

1.2

PHP Version

8.2

Laravel Version

10.41

Which operating systems does with happen with?

No response

Notes

Removing z-10 may solve this issue, but it's uncertain whether it will cause other problems.

activity-icon.blade.php

<div class="relative z-10 w-8 h-8 flex justify-center items-center">
to
<div class="relative w-8 h-8 flex justify-center items-center">
199ocero commented 10 months ago

Thank you for this @hanaexcl ! I will not remove the z-10 but maybe add a scrollable for this. Will be fix for next release.

199ocero commented 10 months ago

Hi @hanaexcl , I go to your fix and I tested if there are any breaking change to layout but seems that there is not. I've added a new release with this fix. Thank youu!

hanaexcl commented 10 months ago

Hi @hanaexcl , I go to your fix and I tested if there are any breaking change to layout but seems that there is not. I've added a new release with this fix. Thank youu!

Thank you, it works!