search

199ocero / activity-timeline

Add timelines to custom pages or infolist entries effortlessly. Plus, it teams up smoothly with Spatie Activitylog for easy tracking.
https://filamentphp.com/plugins/jaocero-activity-timeline
MIT License
65 stars 18 forks source link

[Bug]: Timeline doesn't show Activitylog from null to a value #29

Closed pablo-gonzalez-helpwan closed 2 months ago

pablo-gonzalez-helpwan commented 3 months ago

What happened?

I have a field that changed from null to a string, it is not shown.

I think the issue is on file src/Concerns/HasSetting.php:179, the if uses $oldValues[$key] instead of the newly added $oldValue. So when an old value is null the isset() fails.

How to reproduce the bug

Have a nullable field change to a value.

Package Version

1.2.8

PHP Version

8.3

Laravel Version

11

Which operating systems does with happen with?

Linux

Notes

No response