19lmyers / cse110-w21-group14

1 stars 2 forks source link

Fix memory leaks in dialog windows and other potential areas #73

Closed j1sun closed 3 years ago

j1sun commented 3 years ago

Something interesting the professor said in his CSE134B lecture is that JavaScript's garbage collection won't fire unless all references are gone, including all event listeners begin removed. If this is true, it means that the dialog windows might be removed from the DOM, but it still exists in memory because all the event listeners still exist, leading to performance issues over time. This needs to be fixed in order to prevent memory leaks over a long period of time, but it's also an edge case (not much memory is leaked every time).

Note: Don't tackle this until Week 10, and only if there is time; the leak is small and fixing it is extremely difficult (there's no good way to keep track of memory in this case, so we have to rely on task manager numbers or something else).

https://developers.google.com/web/tools/chrome-devtools/memory-problems/