search

19lmyers / cse110-w21-group14

1 stars 2 forks source link

Jacob screen size fix #87

Closed jkhaliqi closed 3 years ago

jkhaliqi commented 3 years ago

DO NOT MERGE MY CSS FILE, YOU CAN DELETE ALL CHANGES I MADE TO CSS, Other than that the main.js and confirm-dialog.js is good to go and will make keyboard access, automatically set pomo count to 0, and have pop ups for out of range pomo count and empty tasks. IGNORE MY CSS DO NOT MERGE CSS

monmorera commented 3 years ago

@jkhaliqi There is an ESLint error "22:3 error Parsing error: Unexpected token set" in confirm-dialog.js. Is there a way to resolve that? Otherwise ESLint will keep failing.

jkhaliqi commented 3 years ago

The error is in line 22? I only added line 55-57, Ill take a look at it rn

jkhaliqi commented 3 years ago

OK I have no idea what is going on the cancel and end button do not seem to work for me now...We could just wait for Justin to take a look because he did pretty much all of that js file, Sorry!

monmorera commented 3 years ago

I see. Alright then.