search

1Conan / tsschecker

a powerful tool to check tss signing status of various devices and firmwares
GNU Lesser General Public License v3.0
60 stars 15 forks source link

Broken Progressbar (libfragmentzip) #7

Closed DanTheMann15 closed 1 year ago

DanTheMann15 commented 2 years ago

The reason why i disabled the progressbar on windows is because of it having broken text when downloading the buildmanifest with libfragmentzip, along with a duplicate line:

specifically:

←[A←[J100 [===================================================================================================>] ←[A←[J100 [===================================================================================================>]

i recommend not having the progressbar on windows unless it is fixed correctly.

something like this on all platforms: 45% [=======================⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀⠀]

Untitled

DanTheMann15 commented 2 years ago

i just tested the progressbar on linux, same issue there.

here is some sample code i borrowed from libirecovery, i modified it to work with tsschecker: (in a .txt because github has the worst code previews ever in posts. progressbar-patch1.txt

i still need to make sure it can display percentages properly, but it results in this on Windows which looks MUCH better, but it still prints two progressbars when ideally it should just be one. Untitled

the code change however does throw a couple of compiler warnings, but still builds just fine.

here's the log: build_log.txt

any thoughts or suggestions on how i can make this work better?

SwiftMove commented 2 years ago

@DanTheMann15, why does your fork NOT save the "updateInstall" data like this 1Conan fork does?

1Conan shsh2 _ DanTheMann15 shsh2 - ExamDiff Pro, Master Edition (999-User Lic 01-21-2022 01 55 21

DanTheMann15 commented 2 years ago

@DanTheMann15, why does your fork NOT save the "updateInstall" data like this 1Conan fork does?

This issue isn't meant for this topic it's meant for the broken progressbar within tsschecker from fragmentzip.

as for saving UpdateInstall and NoNonce tickets the latest release of my fork of tsschecker saves them just fine. did you compile it yourself and do you mind passing me the parameters you used?

Please continue this discussion here: https://github.com/DanTheMann15/tsschecker/discussions

SwiftMove commented 2 years ago

I'm well aware what this topic is meant for. I would have gladly made a topic about it on your GitHub page, but you didn't have "Issues" turned on, so naturally I decided to address this with you here. I see you've turned the "Issues" section on now, so I'll gladly make a post over there about it.

-EDIT- https://github.com/DanTheMann15/tsschecker/issues/23