search

1EdTech / basiclti-util-java

Apache License 2.0
57 stars 44 forks source link

POXRequest replaceResult: oauth_body_hash #6

Closed bluej100 closed 9 years ago

bluej100 commented 9 years ago

I believe this fixes #3. I've tested against Canvas and Sakai. I apologize for the long delay.

I did a little refactoring here to make testing easier. I tried to keep the diff small.

pfgray commented 9 years ago

Thanks so much for doing this, @bluej100, I really appreciate all of your work!

bluej100 commented 9 years ago

The least I can do, fixing the bug I added. I really appreciate your maintaining this.

bluej100 commented 9 years ago

Would you like me to deploy this to the Maven repository, or is there anything currently in flux?

pfgray commented 9 years ago

No, that would be perfect, thanks. Just bump the patch number

bluej100 commented 9 years ago

(I hope I understood correctly that you meant bump the version to 1.1.1.)

pfgray commented 9 years ago

Yup!

bluej100 commented 9 years ago

I think it's done? I'm getting strangely small release jars in my target directory.

https://oss.sonatype.org/content/groups/public/org/imsglobal/basiclti-util/1.1.1/

bluej100 commented 9 years ago

Fixed. Sorry about that.

https://oss.sonatype.org/content/groups/public/org/imsglobal/basiclti-util/1.1.1/

bluej100 commented 9 years ago

For our future reference:

  mvn install
  mvn source:jar
  mvn javadoc:jar
  cd target
  cp ../pom.xml .
  gpg -ab basiclti-util-1.1.1.jar
  gpg -ab basiclti-util-1.1.1-javadoc.jar
  gpg -ab basiclti-util-1.1.1-sources.jar
  gpg -ab pom.xml
  jar -cvf bundle.jar basiclti-util-1.1.1.jar basiclti-util-1.1.1.jar.asc pom.xml pom.xml.asc basiclti-util-1.1.1-javadoc.jar basiclti-util-1.1.1-javadoc.jar.asc

Log into https://oss.sonatype.org/#stagingRepositories with your credentials from their JIRA, click on Staging Upload, upload bundle.jar as an Artifact Bundle. Next, click on Staging Repositories, find your repository, verify that its contents are correct, and click Release.

bluej100 commented 9 years ago

The new artifacts have been synced to http://repo.maven.apache.org/maven2/org/imsglobal/basiclti-util/1.1.1/ , and I've confirmed them with my local project.