search

1ForeverHD / TopbarPlus

Construct dynamic and intuitive topbar icons. Enhance the appearance and behaviour of these icons with features such as themes, dropdowns and menus.
https://devforum.roblox.com/t/topbarplus/1017485
Mozilla Public License 2.0
105 stars 135 forks source link

Signal doesn't support yielding connections #40

Closed lucasmz-dev closed 2 years ago

lucasmz-dev commented 2 years ago

A yielding connection will cause the next connection to run only after the current connection has stopped yielding. This is unexpected behaviour, especially since I believe this library used a bindable event implementation a while ago, on which this wasn't an issue.

I've encountered this as an issue a while ago since I was messing with tweening menus and I was using Tween.Completed:Wait and I guess you could know what happened.

1ForeverHD commented 2 years ago

You're absolutely correct, this was fixed a few months ago for ZonePlus although it looks like we haven't made the same transition yet (to GoodSignal) for TopbarPlus. This will be fixed for the next release of TopbarPlus although I can't guarantee any times yet.

Thanks for the ticket, I'll close it once the new release is out.