search

1ForeverHD / TopbarPlus

Construct dynamic and intuitive topbar icons. Enhance the appearance and behaviour of these icons with features such as themes, dropdowns and menus.
https://devforum.roblox.com/t/topbarplus/1017485
Mozilla Public License 2.0
95 stars 123 forks source link

Modernize Signal with FastSignal #41

Closed lucasmz-dev closed 2 years ago

lucasmz-dev commented 2 years ago

Closes #40

I done some really basic testing, and as far as I know nothing breaks, but it was a really basic one, if you have any rich tests, I suggest you try testing TopbarPlus with it and seeing if anything breaks.

Any code that broke because of the Signal change from when it was using BindableEvents should know work again, and and some code from now which yields inside connections can break, but it was unexpected behaviour anyway, so... :P If anyone complains from some bug on their code, let them know it's because connections made other connections delay themselves until the other one was done, and so now their code should know how to handle that properly.

Not sure if you will merge this because of your syntax style choice but I hope it's fine 😅

lucasmz-dev commented 2 years ago

I believe this is safe to merge now!

lucasmz-dev commented 2 years ago

Okay, now it is. 😅

Tested it with the playground, everything seems to be working perfectly!