search

1ForeverHD / TopbarPlus

Construct dynamic and intuitive topbar icons. Enhance the appearance and behaviour of these icons with features such as themes, dropdowns and menus.
https://devforum.roblox.com/t/topbarplus/1017485
Mozilla Public License 2.0
91 stars 119 forks source link

Fixed container creating duplicate containers when calling .new() from separate scripts #98

Closed laaeroooo closed 3 months ago

1ForeverHD commented 3 months ago

Hi, for reasons mentioned here...

https://1foreverhd.github.io/TopbarPlus/third_parties/

... the icon container will/should only ever be initialized once. Can you provide details or even better a place file which reproduce this?

laaeroooo commented 3 months ago

Hi, for reasons mentioned here...

https://1foreverhd.github.io/TopbarPlus/third_parties/

... the icon container will/should only ever be initialized once. Can you provide details or even better a place file which reproduce this?

It seems to happen when a script from within an actor creates an icon.

Heres a link to the repro. https://we.tl/t-v8RZ0Bx2Yx

1ForeverHD commented 3 months ago

Okay thanks, I hadn't considered icons being created within actors. For now I recommend avoiding this, and I've added tags so this can be looked into for a later release.

I'm going to close this PR and open an issue instead because it doesn't address the core issue which is the same code being initialized twice within an actor: https://github.com/1ForeverHD/TopbarPlus/issues/99