Closed Evalir closed 4 years ago
I forgot to mention, can we move the "Profile" heading in to the bar with the back button on it?
Thank you so much for the high quality review! Addressed the suggestions, and also took the time to:
EditSidePanel
(character count).PropTypes
and alphabetize components.I forgot to mention, can we move the "Profile" heading in to the bar with the back button on it?
Not really; the Bar
component is not to flexible regarding its placement, and, I'm also following how this combination of components is commonly used (see example)
Note: decided to make the profiles non-nullable fields on the schema. While originally this was to reflect's the DB null state on the profiles, it does not makes sense for the API to return null; it should rather return an empty profile so the frontend can properly handle this case.
Seems ready to be merged when the lint check passes. Do you have anything else you want to add beforehand?
Nothing else! Let me fix the lint check and let's get this merged. 💪
Adds DAO profiles to Apiary, letting users authenticate through web3 & their DAO's ACL to edit profiles stored in the database.
This has been tested both on Rinkeby & Mainnet in a very thorough manner. For reviewers, the
AccountModule
andassets
parts of this PR were extracted from the court dashboard as-is and integrated with Apiary.I'll do some things today to let it fully ready to merge:
Some screenshots: