1Hive / apiary

Aragon DAO explorer
https://apiary.1hive.org
GNU General Public License v3.0
25 stars 16 forks source link

Feature: Add DAO profiles #181

Closed Evalir closed 4 years ago

Evalir commented 4 years ago

Adds DAO profiles to Apiary, letting users authenticate through web3 & their DAO's ACL to edit profiles stored in the database.

This has been tested both on Rinkeby & Mainnet in a very thorough manner. For reviewers, the AccountModule and assets parts of this PR were extracted from the court dashboard as-is and integrated with Apiary.

I'll do some things today to let it fully ready to merge:

Some screenshots:

Screen Shot 2020-04-29 at 4 11 25 AM Screen Shot 2020-04-29 at 4 11 17 AM Screen Shot 2020-04-29 at 4 07 44 AM
onbjerg commented 4 years ago

I forgot to mention, can we move the "Profile" heading in to the bar with the back button on it?

Evalir commented 4 years ago

Thank you so much for the high quality review! Addressed the suggestions, and also took the time to:

  1. Make some UX nicer on the EditSidePanel (character count).
  2. Add PropTypes and alphabetize components.
  3. Avoid overflow on the DataView if a user sets long links.

I forgot to mention, can we move the "Profile" heading in to the bar with the back button on it?

Not really; the Bar component is not to flexible regarding its placement, and, I'm also following how this combination of components is commonly used (see example)

Evalir commented 4 years ago

Note: decided to make the profiles non-nullable fields on the schema. While originally this was to reflect's the DB null state on the profiles, it does not makes sense for the API to return null; it should rather return an empty profile so the frontend can properly handle this case.

onbjerg commented 4 years ago

Seems ready to be merged when the lint check passes. Do you have anything else you want to add beforehand?

Evalir commented 4 years ago

Nothing else! Let me fix the lint check and let's get this merged. 💪