search

1Hive / conviction-voting-app

Aragon app used to collectively allocate funds from a shared treasury 💧
93 stars 32 forks source link

Replaced AragonVault with the FundsManager interface #149

Closed willjgriff closed 2 years ago

willjgriff commented 2 years ago

Abstracted out the Vault responsible for holding funds that conviction voting manages so we can use a Gnosis Safe or an Aragon Vault via a FundsManager interface.

The FundsManager can be viewed in this PR/repo: https://github.com/1Hive/funds-manager/pull/1

There are 2 implementations of the FundsManager interface, one for the AragonVault and one for the GnosisSafe, both include tests.

The funds manager can be updated in Conviction Voting (although users would need to be aware it could make current proposals immediately passable or very hard to pass).

willjgriff commented 2 years ago

LGTM!

What do you think if we take the chance we are working on this repo and we migrate to use Hardhat and update the README.

I don't want to do that in this PR but feel free to make a branch to make those changes. Also personally I'd only do them if they're quick, think there are higher priorities.

willjgriff commented 2 years ago

@0xGabi I've migrated the repo to hardhat, could you check everything seems correct? Also I added a getAccount() method to the utils/networks file used in the config because I don't like using a whole mnemonic for my deployment address, just a single address. Can we use this in other repos if you update them?