Refactor to run in cadCAD 0.4.18

[mzargham]

0.4.18 introduced a configuration class which is was a breaking change with respect to this model given how we pull out the configuration objects for inspection. however it necessitates relatively minor changes to the notebook. i'd like to update v1,v2 (including workshop version), and v3 to run in 0.4.18 if possible. Or if its a more involved update, make sure v3 runs in 0.4.18 and that the local director readmes for earlier models specify which version they use (0.4.17)

[mzargham]

i tagged in @tylerdmace for support since he's already been looking at the 0.4.17 --> 0.4.18 change. Hoping you will tell us this is easy.

[aclarkData]

I thought I had all of these running in 0.4.18. I ran them all yesterday. The main difference was changing to

from cadCAD.configuration import Experiment from appended_configs

[tylerdmace]

I'll double check them all today. I thought you had fixed them, too. Using the new class should be the only change needed I believe, but again, I'll verify here today.

On Tue, Aug 11, 2020, 8:25 AM Andrew Clark notifications@github.com wrote:

I thought I had all of these running in 0.4.18. I ran them all yesterday. The main difference was changing to

from cadCAD.configuration import Experiment from appended_configs

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BlockScience/Aragon_Conviction_Voting/issues/8#issuecomment-671978639, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJN4J6YMZ23FVX3UW65X7DSAFIFNANCNFSM4P2W7DPQ .

[aclarkData]

I just reran v3 - https://github.com/BlockScience/Aragon_Conviction_Voting/blob/master/models/v3/Aragon_Conviction_Voting_Model.ipynb - with no issues. I wonder if Z's machine isn't updated to 0.4.18, or has two versions, and juptyer imported 0.4.17 instead of 0.4.18

[tylerdmace]

Yeah, running the old version after the changes have been made to update the notebook for 0.4.18 would cause similar errors, too. That seems likely to have happened here.

On Tue, Aug 11, 2020, 8:47 AM Andrew Clark notifications@github.com wrote:

I just reran v3 - https://github.com/BlockScience/Aragon_Conviction_Voting/blob/master/models/v3/Aragon_Conviction_Voting_Model.ipynb

• with no issues. I wonder if Z's machine isn't updated to 0.4.18, or has two versions, and juptyer imported 0.4.17 instead of 0.4.18

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/BlockScience/Aragon_Conviction_Voting/issues/8#issuecomment-671991077, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABJN4J6VF7IXGXHGBCAJWF3SAFKWRANCNFSM4P2W7DPQ .

[aclarkData]

I just reran both v1 and v2 as well in the master, all good. v2_assignment doesn't run because Z had pulled some code out for the workshop. @tylerdmace :+1: