search

1Hive / dandelion-voting-app

Contains the Dandelion Voting app which implements an ACLOracle
GNU General Public License v3.0
5 stars 8 forks source link

Dandelion voting subgraph #58

Closed rperez89 closed 4 years ago

rperez89 commented 4 years ago

There are some testing stuffs on the manifest data jsons that will remove later

rperez89 commented 4 years ago

Nicely done!

Looks really good. Was wondering if we should have a Voter entity so we can keep track also of their latestYeaVoteId ? As we have a Juror entity on the court subgraph.

Also i think we should have the settings info of the app as we have in conviction voting?

About the latestYeaVoteId i think about that but not sure if we need it at all, all the validations are done internally on the smart contract, and not sure if we are even using it on app? , about the settings yes sure!

fabriziovigevani commented 4 years ago

About the latestYeaVoteId i think about that but not sure if we need it at all, all the validations are done internally on the smart contract, and not sure if we are even using it on app?

We are not using it currently no, but i think for gardens it will be pretty important to have this info as will be able to give the user more info on why they cannot perform certain action.

rperez89 commented 4 years ago

About the latestYeaVoteId i think about that but not sure if we need it at all, all the validations are done internally on the smart contract, and not sure if we are even using it on app?

We are not using it currently no, but i think for gardens it will be pretty important to have this info as will be able to give the user more info on why they cannot perform certain action.

ok let's see if it's needed and if is needed we can always add it later