Open kamikazebr opened 7 months ago
Just saw we have AccessControl for registry community, do we want this per pool absolutely ? I was thinking maybe we can start with per community allow list and then later support per pool overrides so if a community dont want to reset it for each pool they can do in a more generic way. wdyt ? @kamikazebr @kafann @rperez89 PS: Still need to be implemented in the UI and subgraph so probably not for now but more for actual Beta at the end of the month but with the exact same contract version so we can already push them to auditing.
Just saw we have AccessControl for registry community, do we want this per pool absolutely ? I was thinking maybe we can start with per community allow list and then later support per pool overrides so if a community dont want to reset it for each pool they can do in a more generic way. wdyt ? @kamikazebr @kafann @rperez89 PS: Still need to be implemented in the UI and subgraph so probably not for now but more for actual Beta at the end of the month but with the exact same contract version so we can already push them to auditing.
The thing is that as @pglavin2 suggested we implemented the passport per pool so i think that allowlist should be basically the same, but lets wait for @pglavin2
the reasoning for making Passport per-Pool is to be able to lock down Pools that needed tighter security - i.e. they're holding lots of money, vs. a lower stakes signaling pool.
allowList being per pool is useful beyond that too I think, where you can have different subsections of a community participating in different Pools.
1 community-wide allowList and separate Passport sybil list that any Pool can reference would be helpful, and if that's all we can do for beta launch that sounds OK to me. I do think best UI for this would be letting the Council Safe customize these for each Pool, with the option to default to the Community-wide list. When we first talked about this @Corantin started thinking about roles - but not sure if anything came from that.
Allowlist per Pool/Strategy:
As Sybil System should only allow:
As Grant System:
227