Honeycomb Pending Tasks and Suggestions

befitsandpiper commented 3 years ago

Pending Farming:

[x] Deposit modal not closing after deposit
[x] Update depositdata event based
[ ] Update mywallet more regulary ( add update button?)
[x] Show only allowed networks on airdrop page: https://discord.com/channels/698287700834517064/698287701333377026/849687247513976894
[x] Harvest all button in my deposits list
[x] Add a disclaimer to the staking dialogue ( maybe with a timestamp of the unlock date), to make sure people know they can't withdraw until then
[ ] Link to honeyswap LP creation on farming page
[x] Add a tooltip component and show some info on disabled withdraw/deposit buttons
[ ] Switch to mobile menu on ipad screensize
[x] Remove searchbar if not connected
[x] Make searchbar fullscreen on mywallet page
[ ] Use truncateDecimals on balances in the wallet
[ ] Show liquidity inside pool
[ ] Switch lines on airdrop page https://discord.com/channels/810928904302231562/814913738830381087/849473390288306216
[ ] Change message when not connected to be more informative
[ ] Show pending rewards on the deposit on deposit page
[x] Make the difference between approve and deposit more clear. Show messages for each event.
[x] Notification for successful harvest transaction
[x] Notification for successful withdraw transaction
[x] Fix metamask mobile. (Page does not load )
[x] Show cumulative rewards on deposit page
[x] Reduce number of requests to backend. Properly unmount components ( memory leak )

My wallet:

[ ] Show amount of each token in pair
[ ] Show the pending harvest in the mywallet

Airdrop:

[ ] Add "Add to metamask" button and show *Comb address on airdrop page
[ ] Change text on airdrop page

Global:

[ ] move the pending transaction indicator to the top right near the wallet rather than the top left
[ ] Show the correct name instead of "Etherscan" in the transaction progress

Tulip-Backend:

[x] Update honeyswap subgraph to show derivedeth on matic
[ ] Add zapper.fi api?
[x] Change HoneyComb to Honeycomb
[x] Convert the eth values to dollar according to chain id asset
[ ] Deploy honeyfarm subgraph on matic
[ ] Add celeste staked honey
[ ] Add staked agave

Suggestions:

Make amount/time text-fields
would be nice if it had some preset notches at 25%, 50%, 75% and max, same with days
Fix farming layout on mobile ( generally check everything on mobile )

lkngtn commented 3 years ago

Pending update integrate additional subgraph data. Estimated completion Thursday May 6

pxbee commented 3 years ago

Moved issue list to description

pxbee commented 3 years ago

Suggenstions for the next test

Could the devs may be drop this kind of announcement in the discord a day or two prior to the actual starting of testing (where I assume the users are most active with an at everyone) and advise that they are looking for testers.
Could use like a google form or a hackmd document to get everyone interested to record their addresses.
Mint and distribute the test tokens based on the demand
Could ask some of the initial members to create a simple step based instruction set for other that may not have the necessary skills. This is to be inclusive and also onboard newbies that would do things that a skilled user may not! This is from real life experience where sometimes its best to put it to test by users that have never used it and so will have no bias and do things and break it in unexpected ways!!

pxbee commented 3 years ago

Done Farming:

[x] Grey out withdraw button on "My Deposits" page when the timelock is not up
[x] Update multiplier value in the staking dialogue
[x] Remove Base Yield/Total Yield Columns. Add Reward APY data to column
[x] Make sure that data on the farming page is reloaded after the network is switched
[x] Add APY calculation to the timelock slider in staking modal
[x] Add 1 to the timelock multiplier next to the slider ( currently it starts at 0. It shoud start at 1 )
[x] Increase the number of decimals places of timelock multiplier next to the slider to 2 places. ( So that succeeding days don't show the same value)
[x] Close the staking modal after deposit (Listen to "Transfer" event?)
[x] Change text "for up to 1 year" in staking modal to "for up to ${maxDays} days"
[x] Use symbol names (token0.symbol - token1.symbol) in farm table and deposit table
[x] Show dollar values underneath LP token amount in amount slider and on deposit page
[x] Add a small padding-right to the column headers in the farming table to make sure the headlines are separated
[x] remove vertical scrollbar on wallet page ( small resolution )?
[x] If unlock date is not set change unlock date on my deposits to current date or hide it
[x] In the "My deposits" list, when there is more than 2 deposits, only the last one in the list shows the asset images
[x] In the staking modal, if you don't move the slider and leave it at 0 days, a date in the future is used ( always 2021-07-13 )
[x] Add "search by asset" placeholder to search
[x] Change token image according to network in the "Connect your account to see the farms" dialogue
[x] show infinity yield as 0
[x] Remove pagination
[x] Remove farming banner
[x] Add margin bottom to tables ( around 20 px )
[x] Make searchbar full with on mobile
[x] Make the logo bigger
[x] Recheck if the correct 1hive font is used ( change to everywhere Overpass, sans-serif )
[x] Use whole balance if amount slider is on 100%
[x] Add new version of the WBTC logo to honeyswap repo https://cryptologos.cc/wrapped-bitcoin
[x] underlay logos with white ( transparent logos overlay strangely)

Tulip Backend:

[x] Add chainid parameter to methods
[x] Find token list for matic, check if format is the same as on xdai
[x] Fetch asset/pool data from matic

Search feature:

[x] Search feature farming - when nothing is found show message "No results" instead of "No pairs found"
[x] Search feature wallet - when nothing is found show message "No results" instead of "Connect your account"

Airdrop:

[x] change unclaimed xcomb and claimed amount for correct values
[x] balance is not loading
[x] xcomb & pcomb logo sould be variable depending on the network deployed

MyWallet:

[x] Load Farming value
[x] Agve value not showing up
[x] Honey and weth sometimes is showing the wrong value
[x] Farming values not showing up / race condition?
[x] Add learn more link
[x] Switch between networks

Lending:

[x] Add agave.finance link

Global:

[x] Change wrong network message to say "Please select the xDai or Matic network in your wallet and try again."
[x] Ask about honeycomb logo - should it be linked?
[x] Show default token image if asset logo/image is not found

Philogy commented 3 years ago

For simultaneous, multi-deposit reward withdraws I created the following helper contract: 0x53f224f83b2b2365caf4178f52c234da1ecf392f. Usage is pretty self explanatory if you look at the only method it has (MultiWithdrawer.sol). Only caveat are that the users have to approve the contract via the setApprovalForAll method and that doing multi withdraws are pretty costly, it costs around 80-95k gas / deposit so there has to be some limit enforced in the UI.

1Hive / honeyswap

Honeycomb Pending Tasks and Suggestions #26