search

1Hive / time-lock-app

The Time Lock app enables Aragon organizations to require users transfer or temporarily lock tokens before forwarding an intent.
GNU General Public License v3.0
16 stars 11 forks source link

Enable locking of ETH #41

Open yeqbfgxjiq opened 5 years ago

yeqbfgxjiq commented 5 years ago

Currently only ERC20 tokens are eligible for locking https://github.com/1Hive/lock-app/blob/master/contracts/Lock.sol#L27

It would be great if we could also lock ETH

yeqbfgxjiq commented 5 years ago

This is how it was done on the Token Request app

fabriziovigevani commented 5 years ago

Been doing some tests locally and realized that is not possible at the time to enable locking of ETH due to how the aragon wrapper works.

A check wether the token address is ETH or not has to be made after the wrapper calls the forwardFee() function so it can know if a pre-transaction has to be made or not. Already pinged Brett to check for feasibility and if we could make a PR to aragon/aragon with the enhancement.

lkngtn commented 5 years ago

I'm not sure how difficult this would be, if its easy seems reasonable to support it... but if not I think its fairly reasonable to simply not support ETH for now.

fabriziovigevani commented 5 years ago

I don't think it's too complicated (haven't had a response yet from Brett) but yes i agree it's a nice to have but not entirely necessary.

fabriziovigevani commented 5 years ago

https://github.com/aragon/aragonOS/issues/557

fabriziovigevani commented 4 years ago

There's a payable forwarding interface implemented now. See https://github.com/aragon/aragonOS/pull/583