search

1Hive / time-lock-app

The Time Lock app enables Aragon organizations to require users transfer or temporarily lock tokens before forwarding an intent.
GNU General Public License v3.0
16 stars 11 forks source link

added ETH as token option #45

Closed yeqbfgxjiq closed 5 years ago

yeqbfgxjiq commented 5 years ago

Probably didn't do this right, but looking at the way it was done in the token-request-app it looks like @aragon/os/contracts/common/EtherTokenConstant.sol was imported, and then the token was checked to see if it was ERC20 or ETH, then the function proceeded accordingly. Since lock-app uses the token variable it seemed like it would be easiest to just point that variable to the type of token that is being locked. I changed the initialization of token to uint256 and then the initialize() function defines it as ERC20() or ETH depending on the input. Does that work?

yeqbfgxjiq commented 5 years ago

Looks like CircleCI failed so I def messed this up. Will go back to the drawing board and try again lol