search

1Hive / time-lock-app

The Time Lock app enables Aragon organizations to require users transfer or temporarily lock tokens before forwarding an intent.
GNU General Public License v3.0
16 stars 11 forks source link

Should the name include the term forwarder? #5

Closed willjgriff closed 5 years ago

willjgriff commented 5 years ago

ASFAIK this app is exclusively for forwarding evmscripts on the condition of some deposit being locked. Should it have forwarder in the name to better describe it's functionality? eg lock-forwarder or deposit-forwarder?

lkngtn commented 5 years ago

I'm not sure, I had originally labeled forwarders as such, but this will implement a UI for viewing locks and withdrawing. So its acting as both an App that a user would interact with directly, and as a forwarder which they would only interact with through the signer panel when interacting with a different app.

but I agree that forwarder is a more descriptive (though technical name). I think the crux would be whether we would want this in apm as "lock.open.aragonpm.eth" or "lock-forwarder.open.aragonpm.eth".

yeqbfgxjiq commented 5 years ago

Going through the code to write docs and lock-forwarder would help to make it immediately clear what the lock-app is doing. It locks tokens, then forwards an intent. No lock, no forward. Also fits nicely with the infographic of the dotted line between the user facing apps and the apps that manage tokens.

While the user will be able to interact with the app in multiple ways, I think that adding the word forwarder to the name makes it more clear overall what's happening.