search

1Hive / time-lock-app

The Time Lock app enables Aragon organizations to require users transfer or temporarily lock tokens before forwarding an intent.
GNU General Public License v3.0
16 stars 11 forks source link

Update spam penalty function #75

Closed fabriziovigevani closed 4 years ago

fabriziovigevani commented 4 years ago

closes #65 closes #74

Radspec PR has been merged https://github.com/aragon/radspec/pull/83 so now we could do something like self.getSpamPenalty(msg.sender) in the doc string.

However, the client doesn't have this change yet so updated the doc string to use the contract address for now, so the evaluation wouldn't break.

fabriziovigevani commented 4 years ago

Yes, we will need to change self to msg.sender there.

We'll have to make changes to these contracts when the audit comes through, so we can update it then if it needs to be changed. Provided it's a small change.

Yes was thinking exactly that. Now that we need to have everything ready for audits it made sense to update the function now and update the doc string after the radspec change is available.